Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BGPFilter permissions from EE-only to OSS+EE in apiserver #2617

Merged
merged 1 commit into from
May 2, 2023

Conversation

coutinhop
Copy link
Member

Description

BGPFilters permissions were only being added to apiserver for EE, but they should be for both OSS+EE, this PR does this.

Fixes projectcalico/calico#7598

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@coutinhop coutinhop added the kind/bug Something isn't working label May 2, 2023
@coutinhop coutinhop requested a review from a team as a code owner May 2, 2023 22:14
@marvin-tigera marvin-tigera added this to the v1.30.0 milestone May 2, 2023
@caseydavenport caseydavenport merged commit 5bd5178 into tigera:master May 2, 2023
tmjd added a commit that referenced this pull request May 3, 2023
…elease-v1.29

[release-v1.29] Auto pick #2617: Move BGPFilter permissions from EE-only to OSS+EE in
@coutinhop coutinhop deleted the pedro-fix-bgpfilter-rbac branch May 30, 2023 16:44
@tmjd tmjd modified the milestones: v1.30.0, v1.31.0 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-controller-manager unable to perform normal GC
5 participants