Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check more indicators for EKS discovery [pick 2615, r1.29] #2628

Merged
merged 1 commit into from
May 9, 2023
Merged

Check more indicators for EKS discovery [pick 2615, r1.29] #2628

merged 1 commit into from
May 9, 2023

Conversation

tmjd
Copy link
Member

@tmjd tmjd commented May 8, 2023

Description

Pick #2615

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@tmjd tmjd requested a review from a team as a code owner May 8, 2023 13:11
@marvin-tigera marvin-tigera added this to the v1.29.5 milestone May 8, 2023
@tmjd tmjd merged commit c99b7e5 into tigera:release-v1.29 May 9, 2023
@tmjd tmjd deleted the pick2615-r1.29 branch May 9, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.29.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmjd @caseydavenport @marvin-tigera