Make es-gateway use rolling update instead of recreate strategy #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asincu
force-pushed
the
rolling_deployment_esgw
branch
from
52c3948
to
1e5b7f8
Compare
caseydavenport
approved these changes
May 10, 2023
caseydavenport
approved these changes
May 10, 2023
asincu
force-pushed
the
rolling_deployment_esgw
branch
from
1e5b7f8
to
81d9adf
Compare
asincu
added a commit
to asincu/operator
that referenced
this pull request
May 12, 2023
5 tasks
asincu
added a commit
to asincu/operator
that referenced
this pull request
May 12, 2023
caseydavenport
added a commit
that referenced
this pull request
May 12, 2023
[cherry-pick] Make es-gateway use rolling update instead of recreate strategy (#2632)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update es gateway deployment strategy to use RollingUpdateDeployment instead of Recreate. Will set maxSurge to 100% and maxUnavailable to 0. This will ensure that 2 new pods will be created when rolling out a new version and old ones will be destroyed once all the new ones are up an ready.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.