Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #2779 from sridhartigera/openshift-egw #2782

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Merge pull request #2779 from sridhartigera/openshift-egw #2782

merged 1 commit into from
Aug 1, 2023

Conversation

sridhartigera
Copy link
Contributor

@sridhartigera sridhartigera commented Aug 1, 2023 •
edited

Fix for EGW deployment in openshift 4.13

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@mgleung @sridhartigera
Merge pull request tigera#2779 from sridhartigera/openshift-egw
17dc34a 
Fix for EGW deployment in openshift 4.13
@sridhartigera sridhartigera requested a review from a team as a code owner August 1, 2023 13:21
@marvin-tigera marvin-tigera added this to the v1.29.6 milestone Aug 1, 2023
@mgleung mgleung merged commit 44a6e01 into tigera:release-v1.29 Aug 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgleung mgleung mgleung approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.29.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sridhartigera @mgleung @marvin-tigera