Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.29] Add SecurityContext for Prometheus service container #2789

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

hjiawei
Copy link
Contributor

@hjiawei hjiawei commented Aug 2, 2023

Description

Pick #2784 into release v1.29 branch.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@rene-dekker
Copy link
Member

/merge-when-ready delete-branch

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marvin-tigera
Copy link
Contributor

Removing "merge-when-ready" label due to new commits

@rene-dekker rene-dekker merged commit 0056072 into tigera:release-v1.29 Aug 2, 2023
2 checks passed
@hjiawei hjiawei deleted the prom-svc-sc-129 branch August 3, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants