Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubeControllersConfiguration resource #489

Merged
merged 1 commit into from Apr 6, 2020

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 5, 2020

Signed-off-by: Spike Curtis spike@tigera.io

Description

Add KubeControllersConfiguration CRD, and give kube-controllers RBAC permission to use it.

For PR author

  • Tests for change.

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Release Note

Set calico-kube-controllers RBAC to access KubeControllersConfiguration resource

Signed-off-by: Spike Curtis <spike@tigera.io>
@CLAassistant
Copy link

CLAassistant commented Apr 5, 2020

CLA assistant check
All committers have signed the CLA.

@spikecurtis
Copy link
Contributor Author

/assign @tmjd

Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmjd tmjd added this to the v1.5.0 milestone Apr 6, 2020
@tmjd tmjd added the kind/enhancement New feature or request label Apr 6, 2020
@tmjd tmjd merged commit d980c51 into tigera:master Apr 6, 2020
@tmjd tmjd modified the milestones: v1.5.0, v1.6.0 Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants