Use CNI private for Calico Enterprise installs #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brian-McM
added
enterprise
ozdanborne
reviewed
Apr 17, 2020
|
If we're no longer using OS calico/cni, we should update versions.yml of calico-private accordingly, since it's used to generate the image pull/retag/push instructions for airgapped clusters. Remove this entry: https://github.com/tigera/calico-private/blob/master/_data/versions.yml#L94-L97 And add a new entry for "tigera-cni". I skimmed through the calico-private repo and no other place uses it (except helm charts which i'm removing) |
|
You'll also need to update tigera/process to set "tigera-cni" when it's generating versions.yml to pass to gen-versions. |
Multi NICs is only going to be available for Calico Enterprise installations which is why this change needs to happen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi NICs is only going to be available for Calico Enterprise installations which is why this change needs to happen