Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pick 523] Fix generated files for image ref change (r1.4) #530

Merged
merged 1 commit into from Apr 23, 2020
Merged

[pick 523] Fix generated files for image ref change (r1.4) #530

merged 1 commit into from Apr 23, 2020

Conversation

tmjd
Copy link
Member

@tmjd tmjd commented Apr 22, 2020

Description

Pick #523

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@tmjd tmjd added this to the v1.4.3 milestone Apr 22, 2020
@caseydavenport caseydavenport modified the milestones: v1.4.3, v1.4.4 Apr 22, 2020
@doublek doublek modified the milestones: v1.4.4, v1.4.5 Apr 23, 2020
@tmjd tmjd merged commit 8183de1 into tigera:release-v1.4 Apr 23, 2020
@tmjd tmjd deleted the pick523-r1.4 branch April 23, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmjd @doublek @caseydavenport