Update the default cloudwatch fetch interval to 60sec #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suraiya-Hameed
force-pushed
the
SAAS-671
branch
from
cd2c2ee
to
832c4d1
Compare
Suraiya-Hameed
changed the title
realgaurav
approved these changes
Apr 24, 2020
There was a problem hiding this comment.
lgtm per our conversation.
Please wait for @tmjd's stamp before merging.
doublek
added
enterprise
Suraiya-Hameed
force-pushed
the
SAAS-671
branch
from
832c4d1
to
fb39d41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cloudwatch plugin for EKS reads 1MB of data for every 600s(default
fetchInterval), overtime ES audit logs grows out of sync with cloudwatch logs. With 600secfetchIntervalif we do CRUD operation, the logs appear in cloudwatch immediately, but it never appear in ES audit index or appear after a long gap.This PR reduces the
fetchIntervalto 60sec, it works fine on the test EKS cluster with minimal CRUD operation. There is no additional cost incurred as cloudwatch charges based on data stored and transferred.PR for doc updates https://github.com/tigera/calico-private/pull/2091
Refer:
https://github.com/fluent-plugins-nursery/fluent-plugin-cloudwatch-logs/blob/4239db7b020dcab9d78a630dfc800394e6d2a4a2/lib/fluent/plugin/in_cloudwatch_logs.rb#L131
https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/CloudWatchLogs/Client.html#get_log_events-instance_method
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.