Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update components #570

Merged
merged 2 commits into from May 8, 2020
Merged

Update components #570

merged 2 commits into from May 8, 2020

Conversation

doublek
Copy link
Contributor

@doublek doublek commented May 8, 2020 •
edited

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@doublek doublek added this to the v1.6.0 milestone May 8, 2020
@doublek doublek added enterprise Feature applies to enterprise only kind/enhancement New feature or request labels May 8, 2020
@doublek doublek requested a review from tmjd May 8, 2020 07:18
tmjd
tmjd approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doublek doublek merged commit d0b6953 into tigera:release-v1.6 May 8, 2020
@doublek doublek deleted the update-components branch May 8, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmjd tmjd tmjd approved these changes

Assignees
No one assigned
Labels
enterprise Feature applies to enterprise only kind/enhancement New feature or request
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doublek @tmjd