Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in NodeAddressAutodetectionV6 description #673

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Fix typo in NodeAddressAutodetectionV6 description #673

merged 1 commit into from
Jul 6, 2020

Conversation

arianvp
Copy link
Contributor

@arianvp arianvp commented Jul 2, 2020

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

tmjd
tmjd approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @arianvp

@tmjd tmjd merged commit 6e3262a into tigera:master Jul 6, 2020
@tmjd tmjd changed the title Fix typo Fix typo in NodeAddressAutodetectionV6 description Jul 16, 2020
@tmjd tmjd added this to the v1.9.0 milestone Jul 16, 2020
@tmjd tmjd added the kind/bug Something isn't working label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmjd tmjd tmjd approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arianvp @tmjd