Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make gen-files also generates the deep copies. #679

Merged
merged 1 commit into from
Jul 7, 2020
Merged

make gen-files also generates the deep copies. #679

merged 1 commit into from
Jul 7, 2020

Conversation

tomastigera
Copy link
Contributor

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@caseydavenport caseydavenport merged commit c41fbd8 into tigera:master Jul 7, 2020
@tomastigera tomastigera deleted the tomas-gen-files-fix branch July 7, 2020 18:50
@tmjd tmjd added this to the v1.9.0 milestone Jul 16, 2020
@tmjd tmjd added the kind/bug Something isn't working label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomastigera @caseydavenport @tmjd