Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom Elasticsearch bits #683

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Add custom Elasticsearch bits #683

merged 1 commit into from
Jul 15, 2020

Conversation

doublek
Copy link
Contributor

@doublek doublek commented Jul 8, 2020 •
edited

Description

Change similar to #676 that was made against release-v1.2.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@doublek doublek added enterprise Feature applies to enterprise only kind/enhancement New feature or request labels Jul 8, 2020
@doublek doublek marked this pull request as ready for review July 8, 2020 21:08
rene-dekker
rene-dekker approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@doublek doublek added the hold merge Do not merge label Jul 8, 2020
tmjd
tmjd approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doublek doublek merged commit d59a305 into tigera:master Jul 15, 2020
@doublek doublek deleted the custom-es branch July 15, 2020 23:43
@doublek doublek removed the hold merge Do not merge label Jul 16, 2020
@doublek doublek mentioned this pull request Jul 16, 2020
Merged
5 tasks
@doublek doublek added this to the v1.9.0 milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmjd tmjd tmjd approved these changes

@rene-dekker rene-dekker rene-dekker approved these changes

Assignees
No one assigned
Labels
enterprise Feature applies to enterprise only kind/enhancement New feature or request
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doublek @tmjd @rene-dekker