Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-v1.5 - Cherry-pick status and RBAC changes #668 and #691 #692

Merged
merged 2 commits into from
Jul 13, 2020
Merged

release-v1.5 - Cherry-pick status and RBAC changes #668 and #691 #692

merged 2 commits into from
Jul 13, 2020

Conversation

lmm
Copy link
Contributor

@lmm lmm commented Jul 10, 2020

Description

Pick of #668 and #691

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

tmjd added 2 commits July 10, 2020 15:19
@tmjd @lmm
Merge pull request tigera#668 from lmm/lmm-status
d5c8a99 
Update status once installation CR is written
@tmjd @lmm
Merge pull request tigera#691 from lmm/lmm-rbac
bfd1364 
Remove '*' verbs from operator role.yaml
@lmm lmm changed the title Cherry-pick status and RBAC changes #668 and #691 release-v1.5 - Cherry-pick status and RBAC changes #668 and #691 Jul 10, 2020
tmjd
tmjd approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmjd tmjd merged commit d7c768f into tigera:release-v1.5 Jul 13, 2020
@tmjd tmjd added kind/bug Something isn't working kind/enhancement New feature or request and removed kind/bug Something isn't working labels Jul 14, 2020
@tmjd tmjd added this to the v1.5.2 milestone Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmjd tmjd tmjd approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lmm @tmjd