Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-v1.8 - Cherry-pick status and RBAC changes #668 and #691 #697

Merged
merged 2 commits into from Jul 13, 2020

Conversation

lmm
Copy link
Contributor

@lmm lmm commented Jul 13, 2020

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

tmjd added 2 commits July 13, 2020 10:51
Update status once installation CR is written
Remove '*' verbs from operator role.yaml
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmjd tmjd merged commit f7a823f into tigera:release-v1.8 Jul 13, 2020
@tmjd tmjd added the kind/enhancement New feature or request label Jul 14, 2020
@tmjd tmjd added this to the v1.8.2 milestone Jul 14, 2020
@lmm lmm deleted the lmm-pick-v1.8 branch March 2, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants