Cleanup: render, validation, and defaulting #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseydavenport
force-pushed
the
casey-calico-network-eks
branch
3 times, most recently
from
2ba0dd7
to
3d80a58
Compare
caseydavenport
force-pushed
the
casey-calico-network-eks
branch
from
3d80a58
to
3d5238b
Compare
caseydavenport
added a commit
to caseydavenport/operator
that referenced
this pull request
Jul 27, 2020
* Streamline defaulting and validation * Remove intermediate netconfig structure * Remove outdate render config_test.go * Test fixups * Generate files
5 tasks
caseydavenport
added a commit
that referenced
this pull request
Jul 27, 2020
* Cleanup: render, validation, and defaulting (#705) * Streamline defaulting and validation * Remove intermediate netconfig structure * Remove outdate render config_test.go * Test fixups * Generate files * Allow enabling / disabling BGP (#719) * Changes for Calico networking on EKS (#743) * Changes for Calico networking on EKS * Add tests for Calico Network on EKS * Fix tests after cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.