Override the keystore script #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doublek
force-pushed
the
eck-custom-keystore-init
branch
2 times, most recently
from
0c45e9f
to
3b39b8c
Compare
matthewdupre
approved these changes
Jul 17, 2020
doublek
force-pushed
the
eck-custom-keystore-init
branch
from
3b39b8c
to
1f8d42f
Compare
doublek
added
enterprise
matthewdupre
approved these changes
Jul 17, 2020
matthewdupre
added a commit
that referenced
this pull request
Jul 17, 2020
…gera-release-v1.9 Automated cherry pick of #726: Override the keystore script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Anytime the init container ran (such as on node restarts),
elasticsearch-keystore createfails if the keystore already exists. We useelasticsearch-keystore listto test before callingelasticsearch-keystore create.The
-f was needed forelasticsearch-keystore add-fileotherwise it needed stdin/tty for presenting a confirmation dialogue.Note that this init container is only created by ECK operator when OIDC auth is enabled.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.