Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require requestedScopes for AuthenticationCR #731

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Don't require requestedScopes for AuthenticationCR #731

merged 1 commit into from
Jul 21, 2020

Conversation

Brian-McM
Copy link
Contributor

@Brian-McM Brian-McM commented Jul 20, 2020

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@Brian-McM Brian-McM added enterprise Feature applies to enterprise only kind/bug Something isn't working labels Jul 20, 2020
@Brian-McM Brian-McM added this to the v1.9.0 milestone Jul 20, 2020
@tmjd
Copy link
Member

tmjd commented Jul 21, 2020

I think this PR needs to be rebased on master to fix the tests.

@Brian-McM Brian-McM merged commit 50e3f9b into tigera:master Jul 21, 2020
@Brian-McM Brian-McM deleted the add-omit-empty-json-tag branch July 21, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise Feature applies to enterprise only kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants