Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass OIDC prefixes from Authentication CR to KubeControllers #744

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Pass OIDC prefixes from Authentication CR to KubeControllers #744

merged 1 commit into from
Jul 23, 2020

Conversation

Brian-McM
Copy link
Contributor

@Brian-McM Brian-McM commented Jul 22, 2020 •
edited

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@Brian-McM Brian-McM added enterprise Feature applies to enterprise only kind/bug Something isn't working labels Jul 22, 2020
@Brian-McM Brian-McM added this to the v1.9.0 milestone Jul 22, 2020
matthewdupre
matthewdupre reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@matthewdupre matthewdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at the tests yet

pkg/controller/installation/core_controller.go Outdated Show resolved Hide resolved
pkg/controller/logstorage/logstorage_controller.go Show resolved Hide resolved
pkg/controller/utils/utils.go Show resolved Hide resolved
@Brian-McM Brian-McM merged commit 339a759 into tigera:master Jul 23, 2020
@Brian-McM Brian-McM deleted the bm-set-kube-controller-oidc-prefix-env-variables branch July 23, 2020 18:02
@Brian-McM Brian-McM mentioned this pull request Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdupre matthewdupre matthewdupre approved these changes

Assignees
No one assigned
Labels
enterprise Feature applies to enterprise only kind/bug Something isn't working
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Brian-McM @matthewdupre