Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick #742: include v1beta1 amazoncloudintegration in crds #750

Merged
merged 1 commit into from
Jul 23, 2020
Merged

cherry-pick #742: include v1beta1 amazoncloudintegration in crds #750

merged 1 commit into from
Jul 23, 2020

Conversation

ozdanborne
Copy link
Member

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@tmjd tmjd added this to the v1.9.0 milestone Jul 23, 2020
@tmjd tmjd added the enterprise Feature applies to enterprise only label Jul 23, 2020
tmjd
tmjd approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozdanborne ozdanborne merged commit 2d74e93 into tigera:release-v1.9 Jul 23, 2020
@ozdanborne ozdanborne deleted the release-v1.9 branch July 23, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmjd tmjd tmjd approved these changes

Assignees
No one assigned
Labels
enterprise Feature applies to enterprise only
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ozdanborne @tmjd