Set routeSource in Felix configuration to WorkloadIPs for aws-vpc CNI #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realgaurav
force-pushed
the
calico-4policy-routesrc
branch
from
f4d64eb
to
5125cdf
Compare
realgaurav
force-pushed
the
calico-4policy-routesrc
branch
from
5125cdf
to
f83fe78
Compare
caseydavenport
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set
routeSourcein Felix configuration toWorkloadIPsfor aws-vpc CNI.Default value for
routeSourcein Felix configuration isCalicoIPAM. With value set toCalicoIPAM, dataplane in Felix doesn't get RouteUpdate for remote workloads manifesting into route issues for encryption functionality.For PR author
If changing pkg/apis/, runmake gen-filesIf changing versions, runmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.