Merge pull request #871 from tigerbeetledb/dj-vsr-op-checkpoint-uncer…

…tain VSR: op_certain=false when op_checkpoint is faulty
tigerbeetle · Jun 13, 2023 · 8f362b0 · 8f362b0
2 parents ca5b758 + 8e2779b
commit 8f362b0
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/vsr/replica.zig b/src/vsr/replica.zig
@@ -4355,6 +4355,11 @@ pub fn ReplicaType(
             // slot may have originally been op that is a wrap ahead.
             if (self.journal.faulty.bit(slot_op_head)) return false;
 
+            // If faulty, this slot may hold either:
+            // - op=op_checkpoint, or
+            // - op=op_checkpoint_trigger
+            if (self.journal.faulty.bit(slot_op_checkpoint)) return false;
+
             const slot_known_range = vsr.SlotRange{
                 .head = slot_op_checkpoint,
                 .tail = slot_op_head,