LSM: Switch forest fuzz to stdx.equal_bytes #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std.mem.eql and casting to bytes hid the fact that we were now incorrectly comparing a double pointer to a single pointer. Change to stdx.equal_bytes for some nice type safety, and fix the bug.
|
(something funky was up with my build, just double checking) Ah - #1239 |
|
Reminds me that I wanted to vendor better version of
This was blocked by ziglang/zig#16245 before, but I think this now is in 0.11? Anway, that's future work! |
matklad
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std.mem.eqlandasByteshid the fact that we were now incorrectly comparing a double pointer to a single pointer.Change to
stdx.equal_bytesfor some nice type safety, and fix the bug.