Commits on Nov 7, 2023

1. ci: more robust handling of directories in shell.zig …

   We use shell.zig for various "scripting" tasks. One problem there is
   managing environment --- current directory and environmental variables.
   
   So far, the strategy was to avoid doing anything special about it and
   just use std API to mutate global process state. That's not great, for
   two reasons:
   
   - First, mutating process state is inherently fragile. For example,
     calling setenv in a multithreaded program is almost always UB
   
   - Second, mutating global state might lead to logical errors. For
     example, we had a bug recently where `foo` called `bar`, `bar` changed
     process working directory, and, upon return, `foo` ended up in an
     unexpected state. (#1272)
   
   To fix the issues, this PR phases our global API in favor of `Shell.cwd`
   field.
   
   Trivia: in most other languages, adding a second cwd would be quite
   confusing, as that would make the `std` API behave in unexpected ways.
   However in Zig the cwd is not ambient, but rather passed explicitly to
   almost all APIs:
   
       std.fs.cwd().readFle("Readme.me")
   
   So there's no confusion!

   

   matklad committed Nov 7, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 7ab58d7
   • Browse repository at this point

   Copy the full SHA

   7ab58d7 View commit details

   Browse the repository at this point in the history

2. ci: use more robust pushd/popd API

   

   matklad committed Nov 7, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for b7dca29
   • Browse repository at this point

   Copy the full SHA

   b7dca29 View commit details

   Browse the repository at this point in the history