don't mix tabs and spaces in bootstrap.sh #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you're here, can you add it to the |
bootstarp.sh is probably something people would look at to learn how to download tigerbeetle, it should be readable.
matklad
force-pushed
the
matklad/dont-mix-tabs-and-spaces
branch
from
a4eaaf0
to
1c8ebb2
Compare
|
Good call, though it seems that shellcheck is fine about mixing tabs&spaces here? |
|
As an aside, ignoring style preferences, there is one place where "spaces vs tabs" actually matters in shell scripts -- heredocs work better with tabs. (e.g. https://tldp.org/LDP/abs/html/here-docs.html example 19-4). |
I was quite surprised by this too, given how opinionated they are on other things! |
cb22
approved these changes
Nov 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bootstarp.sh is probably something people would look at to learn how to download tigerbeetle, it should be readable.