Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: last goes callback #1318

Merged
merged 1 commit into from Nov 22, 2023
Merged

style: last goes callback #1318

merged 1 commit into from Nov 22, 2023

Conversation

matklad
Copy link
Member

@matklad matklad commented Nov 22, 2023 •
edited

Context: #1309 (comment)

sentientwaffle
sentientwaffle approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@sentientwaffle sentientwaffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion: #1309 (comment)

@sentientwaffle
Copy link
Member

Ah, you included the discussion in your original post and I didn't notice 🤦

@matklad
Copy link
Member Author

matklad commented Nov 22, 2023 •
edited

It was a ninja edit. Let me actually add this to the commit message, so that its recorded in git...

@matklad matklad added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 7a1f803 Nov 22, 2023
27 checks passed
@matklad matklad deleted the matklad/call-back-maybe branch November 22, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentientwaffle sentientwaffle sentientwaffle approved these changes

Assignees

@sentientwaffle sentientwaffle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matklad @sentientwaffle