vsr: verify that FreeSet index is consistent #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
force-pushed
the
matklad/verify-free-set-index
branch
from
7b26eee
to
f8adc26
Compare
None of our fuzzers actually checks that. In theory, the simulator can discover inconsistencies when a replica restarts (decoding free set from disk resets the index), but, given that the shard size is 4096, this is quite unlikely. With this change, injecting a bug in index computation gets discovered by free set fuzzer at least. See #1309 (comment) for an example of a bug this assert guards against.
matklad
force-pushed
the
matklad/verify-free-set-index
branch
from
f8adc26
to
076bc77
Compare
sentientwaffle
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of our fuzzers actually checks that. In theory, the simulator can discover inconsistencies when a replica restarts (decoding free set from disk resets the index), but, given that the shard size is 4096, this is quite unlikely.
With this change, injecting a bug in index computation gets discovered by free set fuzzer at least.