vsr: make comptime checksum(&.{}) available everywhere
#1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batiati
reviewed
Nov 30, 2023
src/vsr/checksum.zig
Outdated
| test "checksum empty" { | ||
| var stream = ChecksumStream.init(); | ||
| stream.add(&.{}); | ||
| assert(stream.checksum() == comptime checksum(&.{})); |
matklad
force-pushed
the
matklad/checksum-empty
branch
from
e868447
to
119d25e
Compare
|
I think this is an improvement as-is, I'll update free-set parts separately, when #1332 merges. |
I have a bunch of asserts on the empty checksum in free set, and writing
`assert(checksum = vsr.checksum(&.{}))` makes me hesitate, as that
involves non-trivial runtime computation. So let's make
comptime vsr.checksum(&.{})
JustWork, so that's a no-brainer for the future.
matklad
force-pushed
the
matklad/checksum-empty
branch
from
119d25e
to
047c5ff
Compare
batiati
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a bunch of asserts on the empty checksum in free set, and writing
assert(checksum = vsr.checksum(&.{}))makes me hesitate, as that involves non-trivial runtime computation. So let's makeJustWork, so that's a no-brainer for the future.