Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vopr: account for state sync in the convergence checker #1381

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

matklad
Copy link
Member

@matklad matklad commented Dec 20, 2023

It's normal for a core of a cluster to be missing some prepares, as long as they are from a past checkpoint.

SEED: 3206062160591889559

closes: #1370

It's normal for a core of a cluster to be missing some prepares, as long
as they are from a past checkpoint.

SEED: 3206062160591889559
src/simulator.zig Outdated Show resolved Hide resolved
Co-authored-by: djg <sentientwaffle@gmail.com>
@matklad matklad added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit 724257e Dec 20, 2023
27 checks passed
@matklad matklad deleted the matklad/relax-convergence-around-checkpoint branch December 20, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

liveness seed=7880408371515809323
2 participants