Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: smoke fuzz free_set #1410

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fuzz: smoke fuzz free_set #1410

merged 1 commit into from
Jan 10, 2024

Conversation

matklad
Copy link
Member

@matklad matklad commented Jan 9, 2024

NB: with 123 seed, we are hitting the 0 branch at

.release = if (random.boolean()) 0 else 500 * random.float(f64),

I am not going to fix this here, but perhaps long term smoke fuzzing
should run for a range of seeds?

NB: with 123 seed, we are hitting the 0 branch at

```
.release = if (random.boolean()) 0 else 500 * random.float(f64),
```

I am not going to fix this here, but perhaps long term smoke fuzzing
should run for a _range_ of seeds?
@matklad matklad marked this pull request as ready for review January 10, 2024 10:19
@matklad
Copy link
Member Author

matklad commented Jan 10, 2024

I am not going to fix this here, but perhaps long term smoke fuzzing
should run for a range of seeds?

This shold be fixed by replacing .seed = 123 with .seed = $(git rev-parse HEAD)

@matklad
Copy link
Member Author

matklad commented Jan 10, 2024

(in a follow-up that is)

@matklad matklad added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit 02171a6 Jan 10, 2024
25 checks passed
@matklad matklad deleted the matklad/fuzzers-5 branch January 10, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants