Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: main on top #1421

Merged
merged 2 commits into from
Jan 16, 2024
Merged

style: main on top #1421

merged 2 commits into from
Jan 16, 2024

Conversation

matklad
Copy link
Member

@matklad matklad commented Jan 11, 2024

We are horribly inconsistent here!

  1. main first: tigerbeetle, simulator, scripts, half of the fuzzers
  2. main last: aof.zig, docs_generate.zig, (go,dotnet,node)_bindings, half of the fuzzers

Zig is not C, it deliberately allows declarations to be in any order, and I'd say writing and reading code top down

https://www.teamten.com/lawrence/programming/write-code-top-down.html

is much more human friendly.

jorangreef
jorangreef previously approved these changes Jan 15, 2024
docs/TIGER_STYLE.md Outdated Show resolved Hide resolved
Comment on lines +275 to +276
At the same time, not everything has a single right order. When in doubt, consider sorting
alphabetically, taking advantage of big-endian naming.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

Co-authored-by: Joran Dirk Greef <joran@tigerbeetle.com>
@matklad matklad added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit 31f0ccf Jan 16, 2024
25 checks passed
@matklad matklad deleted the matklad/main-on-top branch January 16, 2024 16:01
matklad added a commit that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants