Update docs/DEEP_DIVE.md for zig changes #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure is a spellcheck. It identifies one preexisting typo in DEEP_DIVE.md that I am not fixing here since presumably somebody else is looking at those. |
|
Oh the spelling error is part of this diff so I guess I must fix it to pass CI. |
matklad
reviewed
Jan 17, 2024
| - Open `src/config.zig` in your editor and change `log_level` to `.debug`. | ||
|
|
||
| - Rebuild TigerBeetle using the new debug log level by running `zig/zig build -Drelease && mv zig-out/bin/tigerbeetle .` | ||
| - Rebuild TigerBeetle with the debug log level by running `zig/zig build -Drelease -Dconfig-log-level=debug` |
There was a problem hiding this comment.
One item in our infinite TODO list is "make log level configurable at runtime"
| zig/zig run src/demos/demo_01_create_accounts.zig --pkg-begin vsr src/vsr.zig | ||
| zig/zig run src/demos/demo_02_lookup_accounts.zig --pkg-begin vsr src/vsr.zig | ||
| zig/zig run src/demos/demo_01_create_accounts.zig --deps vsr --mod vsr::src/vsr.zig | ||
| zig/zig run src/demos/demo_02_lookup_accounts.zig --deps vsr --mod vsr::src/vsr.zig |
brson
force-pushed
the
deep-dive-update
branch
from
9678ad3
to
15e537d
Compare
|
@matklad I rebased this onto the new main branch. |
matklad
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this useful doc and tried to run through it. It needs some updates.
Setting the
log_levelvariable onconfig.zigdoes not work as described. It can be set on the command line while building.The
--pkg-beginflag no longer exists.Also, the results I got running this tutorial contradicted what the text says should happen. I'll file a separate issue about it since I don't understand enough to just fix it. (#1432)