Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration tests #1474

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Improve integration tests #1474

merged 5 commits into from
Jan 26, 2024

Conversation

batiati
Copy link
Contributor

@batiati batiati commented Jan 25, 2024

While investigating this Rafik issue, I noticed that our Node.js CI passes even if tests fail.

  • Ensure that the Node.js test runner returns a non-zero exit code when tests fail.
  • Add Node, Java, and Dotnet tests for pending_transfer_expired.

matklad
matklad previously approved these changes Jan 25, 2024
@batiati batiati added this pull request to the merge queue Jan 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 25, 2024
@matklad
Copy link
Member

matklad commented Jan 25, 2024

Failure seems legit:

    Failed CreatePendingTransfersAndVoidExpiredAsync [6 s]
    Error Message:
     Assert.IsTrue failed. 
    Stack Trace:
       at TigerBeetle.Tests.IntegrationTests.CreatePendingTransfersAndVoidExpiredAsync() in /home/runner/work/tigerbeetle/tigerbeetle/src/clients/dotnet/TigerBeetle.Tests/IntegrationTests.cs:line 723

@batiati
Copy link
Contributor Author

batiati commented Jan 26, 2024

Failure seems legit:

Looks like Task.Delay does not have accurate resolution and sometimes finishes sooner than the timeout 😨.
Kind of the same problem here: WalletWasabi/WalletWasabi#6166

@batiati batiati added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 6c2cfd7 Jan 26, 2024
25 checks passed
@batiati batiati deleted the batiati-fix-tests branch January 26, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants