VSR: Perform checkpoint steps concurrently #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`checkpoint_state_machine`'s job is to flush manifest log blocks to the grid. It doesn't ever read blocks, so it can never get stuck waiting for grid repair. Thus, no need to cancel the grid, we can just wait for it to finish naturally.
Instead of performing the checkpoint steps sequentially, perform them concurrently: - `checkpoint_state_machine` - `checkpoint_client_replies` - `checkpoint_client_sessions` Notes: - `forest.zig`: There may (now) be non-repair grid-writes while we are flushing the manifest log blocks – we are concurrently flushing the trailers at the same time.
sentientwaffle
commented
Feb 2, 2024
| @@ -438,7 +438,6 @@ pub fn ForestType(comptime _Storage: type, comptime groove_cfg: anytype) type { | |||
| const forest = @fieldParentPtr(Forest, "manifest_log", manifest_log); | |||
| assert(forest.progress.? == .checkpoint); | |||
| assert(forest.manifest_log_progress == .idle); | |||
| forest.grid.assert_only_repairing(); | |||
There was a problem hiding this comment.
There may (now) be non-repair grid-writes while we are flushing the manifest log blocks – we are concurrently flushing the trailers at the same time.
matklad
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of performing the checkpoint steps sequentially, perform them concurrently:
checkpoint_state_machinecheckpoint_client_repliescheckpoint_client_sessionsThis PR doesn't make
checkpoint_gridconcurrent -- that will be in a follow-up PR since it is slightly more involved.