VSR: Assert request header fields #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A request's index number and message checksum are both included in the corresponding reply message. Verify that they match!
matklad
reviewed
Feb 7, 2024
src/vsr/message_header.zig
Outdated
| @@ -738,6 +738,7 @@ pub const Header = extern struct { | |||
| replica: u8, | |||
| reserved_frame: [16]u8 = [_]u8{0} ** 16, | |||
|
|
|||
| /// The checksum of the corresponding Request. | |||
| parent: u128, | |||
sentientwaffle
force-pushed
the
dj-vsr-request-asserts
branch
from
78e70c6
to
2561700
Compare
matklad
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A request's index number and message checksum are both also included in the corresponding reply message.
Verify that they match!