[Go] Add client batching integration tests #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kprotty
reviewed
Feb 14, 2024
| TIGERBEETLE_CLUSTER_ID uint64 = 0 | ||
| TIGERBEETLE_REPLICA_ID uint32 = 0 | ||
| TIGERBEETLE_REPLICA_COUNT uint32 = 1 | ||
| TIGERBEETLE_CONCURRENCY_MAX uint = 4096 |
There was a problem hiding this comment.
Should we bump this to 8192 to reflect the value in tb_client/context.zig?
There was a problem hiding this comment.
Looks like the way we handle TooManyOutstanding isn't quite right. This test exposes a bug when running with concurrency_max higher than the size of the DemuxPool (which is 4096).
There was a problem hiding this comment.
Ah I see. tb_client wasn't adjusted properly after DemuxPool was introduced. It should be addressed by the intrusive packets PR at least.
Yes, it took just a few seconds (< 10s) to run. |
kprotty
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.