devhub: use commit timestamp to enable retrospective benchmarking #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to https://nyrk.io folks for point out the drawbacks of using wall-clock time. You might ask --- why include commit timestamp if we already have the hash? The reason is, commit timestamp is what determines ordering of data --- you can't say which of the two commit hashes comes earlier.
cb22
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to https://nyrk.io folks for point out the drawbacks of using wall-clock time.
You might ask --- why include commit timestamp if we already have the hash? The reason is, commit timestamp is what determines ordering of data --- you can't say which of the two commit hashes comes earlier.