ci: don't special case benchmark testing #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
commented
Feb 19, 2024
| @@ -388,7 +388,7 @@ pub fn exec_options( | |||
| } | |||
| } | |||
|
|
|||
| /// Returns `true` if the command executed successfully with a zero exit code and an empty stderr. | |||
| /// Returns `true` if the command executed successfully with a zero exit code. | |||
There was a problem hiding this comment.
This is the second time the stderr check gets in the way (as benchmark logs to stderr). Before that, I get a false error somewhere where I was running tool --version, and was getting print out to stderr about the tool being installed transparently by some sort of version manager. So I figured it's better to keep it simple and just not check for stderr.
matklad
force-pushed
the
matklad/smoke-benchmark
branch
from
1797128
to
874a6c2
Compare
As per O(1) build files, benchmark is not special enough to warrant a dedicate space in the yamls. Move it to the integration tests. Even in debug, it's fast enough to run. The release mode is exercised by the devhub.
matklad
force-pushed
the
matklad/smoke-benchmark
branch
from
874a6c2
to
81ab431
Compare
cb22
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per O(1) build files, benchmark is not special enough to warrant a dedicate space in the yamls. Move it to the integration tests. Even in debug, it's fast enough to run.
The release mode is exercised by the devhub.