Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One day we should go and just add proper quoting support, where " interpolates and ' doesn't, but I am not ready to do that just yet. Maybe one day `std.shlex` becomes a thing even!
https://nyrk.io is a cloud CI benchmark tracking service. It is very similar to what devhub is doing, except that it actually is a real project, and not just me copy-pasting JavaScript from https://deno.com/benchmarks. Otherwise, it is very similar --- their data model is isomorphic to what we already use. In this PR, we duplicate data to both devhubdb and nyrk. I think we'll continue in this mode for some time, but I can see us switching to nyrk 100% in the future. In a follow up, I do want to switch to nyrk-shaped json for devhubdb as well, as I like their version more (esp grouping attributes _separately_ from the timestamp, which is the primary key), but I don't want to change stuff on our end right away. As nyrk is a 3rd party service, I don't fail CI job if we fail to upload.
matklad
force-pushed
the
matklad/nyrkiö
branch
from
b097ada
to
b1ecedf
Compare
cb22
reviewed
Feb 27, 2024
| fn upload_nyrkio(shell: *Shell, run: NyrkioRun) !void { | ||
| const token = try shell.env_get("NYRKIO_TOKEN"); | ||
| const payload = try std.json.stringifyAlloc(shell.arena.allocator(), [_]NyrkioRun{run}, .{}); | ||
| try shell.exec( |
There was a problem hiding this comment.
No love for std.http.Client? 😉
There was a problem hiding this comment.
Wait, we already have http.Client? Didn't realize that, thought that's the next release. But, given ziglang/zig#18955, I'd probably let it bake a bit more until we depend on it
cb22
approved these changes
Feb 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Failure feels like something's wrong with actions/checkpout? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nyrk.io/ is a cloud CI benchmark tracking service.
It is very similar to what devhub is doing, except that it actually is a
real project, and not just me copy-pasting JavaScript from
https://deno.com/benchmarks.
Otherwise, it is very similar --- their data model is isomorphic to what
we already use.
In this PR, we duplicate data to both devhubdb and nyrk. I think we'll
continue in this mode for some time, but I can see us switching to nyrk
100% in the future.
In a follow up, I do want to switch to nyrk-shaped json for devhubdb as
well, as I like their version more (esp grouping attributes separately
from the timestamp, which is the primary key), but I don't want to
change stuff on our end right away.
As nyrk is a 3rd party service, I don't fail CI job if we fail to
upload.