Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsr: prevent state sync from breaking hash chain #1598

Merged
merged 2 commits into from
Feb 27, 2024
Merged

vsr: prevent state sync from breaking hash chain #1598

merged 2 commits into from
Feb 27, 2024

Commits on Feb 27, 2024

  1. vsr: prevent state sync from breaking hash chain 

    The added test is a minimization of #1532.

If replica state-syncs into a newer view, its log may be disconnected
from a checkpoint. To fix this, require that replica jumps view before
jumping sync target.

The effect here is that, after state sync, there's _still_ a break
between the checkpoint and the log, but, as replica is in a view_change
state, it doesn't assume valid hash chain and waits until an SV to
correct the log.

SEED: 17270152460592452540
Closes: #1532
    @matklad
    matklad committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    eced32a View commit details
    Browse the repository at this point in the history

  2. vsr: clarify that checking view_durable is not needed in jump_sync 

    It is correct to check only view, not view_durable here. This can't lead
to a situation where we crash and restart with an older view and a newer
sync target, because superblock updates are serialized.
    @matklad
    matklad committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    058b7c8 View commit details
    Browse the repository at this point in the history