Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSR: Log the view that we compare against (view_durable) #1654

Merged
merged 2 commits into from Mar 6, 2024
Merged

VSR: Log the view that we compare against (view_durable) #1654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b54aca
VSR: Log the view that we compare against (view_durable)
sentientwaffle Mar 5, 2024
2b243d1
VSR: Log vsr.Status more succinctly
sentientwaffle Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/vsr/replica.zig
View file
Open in desktop
Expand Up @@ -1162,10 +1162,10 @@ pub fn ReplicaType(
// Switch on the header type so that we don't log opaque bytes for the per-command data.
switch (message.header.into_any()) {
inline else => |header| {
log.debug("{}: on_message: view={} status={} {}", .{
log.debug("{}: on_message: view={} status={s} {}", .{
self.replica,
self.view,
self.status,
@tagName(self.status),
header,
});
},
Expand Down Expand Up @@ -8392,10 +8392,11 @@ pub fn ReplicaType(

if (candidate.view > self.view_durable()) {
log.mark.debug("{}: on_{s}: jump_sync_target: ignoring, newer view" ++
" (view={} candidate.view={})", .{
" (view={} view_durable={} candidate.view={})", .{
self.replica,
@tagName(header.command),
self.view,
self.view_durable(),
candidate.view,
});
return;
Expand Down