VSR: SuperBlock.VSRState.CheckpointState.release #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To disambiguate from the "release version".
sentientwaffle
force-pushed
the
dj-vsr-superblock-release
branch
from
8061745
to
b0ffad5
Compare
Upgrades will bump this release number via a checkpoint.
sentientwaffle
force-pushed
the
dj-vsr-superblock-release
branch
from
b0ffad5
to
8f63fc8
Compare
Reply release should mirror prepare release!
sentientwaffle
force-pushed
the
dj-vsr-superblock-release
branch
from
e6093e8
to
e920f13
Compare
sentientwaffle
commented
Mar 8, 2024
| @@ -513,7 +516,7 @@ pub fn Client(comptime StateMachine_: type, comptime MessageBus: type) type { | |||
| } | |||
|
|
|||
| /// Releases a message back to the message bus. | |||
| pub fn release(self: *Self, message: *Message) void { | |||
| pub fn release_message(self: *Self, message: *Message) void { | |||
There was a problem hiding this comment.
I prefer release_message to release even ignoring the name collision -- it mirrors get_message.
matklad
reviewed
Mar 8, 2024
| @@ -354,11 +356,13 @@ pub const SuperBlockHeader = extern struct { | |||
| /// The number of manifest blocks in the manifest log. | |||
| manifest_block_count: u32, | |||
|
|
|||
| release: u16, | |||
There was a problem hiding this comment.
Document semantics --- all prepares within this checkpoint were executed by a replica with a given release. That is, this applies not only to checkpoint_op, but to the entire log wrap of ops.
matklad
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some miscellaneous prerequisites for upgrades:
Client.release()/Client.release_message(): To disambiguate from the "release version".Replica.release,Replica.release_client_min, andClient.release. (release_client_minisn't check yetSuperBlock.VSRState.CheckpointState.release: Upgrades will bump this release number via a checkpoint.