Fixes a scan_buffer_pool leak
#1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `get_account_balances` was called with an invalid account or an account without `flags.history == true`, then the `scan_buffer_pool` would not be reset for the next call with a valid filter. It also writes unit tests that reproduce the bug.
sentientwaffle
approved these changes
Mar 18, 2024
| } | ||
|
|
||
| // TODO(batiati): Improve the way we do validations on the state machine. | ||
| log.info( | ||
| "invalid filter for get_account_balances: {any}", |
There was a problem hiding this comment.
I think this error message is not necessarily correct anymore. Unless querying an account that doesn't exist or doesn't set history qualifies as an "invalid filter"? But we can fix this later, seeing as this is just placeholder error handling anyhow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
get_account_balanceswas called with an invalid account or an account withoutflags.history == true, then thescan_buffer_poolwould not be reset for the next call with a valid filter.It also writes unit tests that reproduce the bug.