[REPL] Implement get_account_transfers and get_account_balances
#1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Mar 21, 2024
| \\create_transfers, or lookup_transfers. Got: '{s}'. | ||
| \\ | ||
| , | ||
| "Operation must be " ++ |
There was a problem hiding this comment.
Suggested change
| "Operation must be " ++ | |
| "Operation must be one of " ++ |
we are dropping or, so let's add one of so that it still reads naturally. Or maybe do
|operation, index|
const separator = if (index == 0) " " else if (index == Operation.len - 1) "or " else ","
There was a problem hiding this comment.
Using Oxford commas 😸
| result, | ||
| ); | ||
|
|
||
| if (get_account_transfers_results.len == 0) { |
There was a problem hiding this comment.
Hm, but we should get no results if the account wasn't transacted against?
There was a problem hiding this comment.
likewise in lookup_accounts and lookup_transfers! I'm going to drop the word "Failed" then.
matklad
approved these changes
Mar 21, 2024
Comment on lines
+416
to
+418
| (if (names.len > 0) ", " else "") ++ | ||
| (if (index == std.enums.values(Operation).len - 1) "or " else "") ++ | ||
| @tagName(operation); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.