Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfo: successful seeds are displayed for pull request #1945

Merged
merged 1 commit into from
May 13, 2024

Conversation

matklad
Copy link
Member

@matklad matklad commented May 12, 2024

When fuzzing my PRs, I've found myself double-checking if I used correct
label names. To make the set of fuzzers run for a PR more obvious,
let's include successful seeds from PRs and color-code them green.

I debated whether this should be done for the main branch as well, but I
think it's better not to, as the number of fuzzers in general can get
rather large!

I also debated whether I should stop showing canary entries, but I think
it's better to keep those, as the purpose is different:

  • canary demonstrates that the fuzzer is capable of failing
  • the green seeds demonstrate the narrow set of fuzzers used for a PR

When fuzzing my PRs, I've found myself double-checking if I used correct
branch names. To make the set of fuzzers run for a PR more obvious,
let's include successful seeds from PRs and color-code them green.

I debated whether this should be done for the main branch as well, but I
think it's better not to, as the number of fuzzers in general can get
rather large!

I also debated whether I should stop showing canary entries, but I think
it's better to keep those, as the purpose is different:

* canary demonstrates that the fuzzer is capable of failing
* the green seeds demonstrate the narrow set of fuzzers used for a PR
@matklad
Copy link
Member Author

matklad commented May 12, 2024

image

}
rowDom.style.setProperty(
"background",
record.ok ? "#CF0" : colors[commit_count % colors.length],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@matklad matklad added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit afc591a May 13, 2024
25 checks passed
@matklad matklad deleted the matklad/cfo-green-pull-requests branch May 13, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants