io: remove dead benchmark #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This benchmark doesn't compile, and it looks like it wansn't even ported to Zig 0.11. As we don't actively need it, remove it
matklad
commented
May 16, 2024
| @@ -147,7 +147,6 @@ const DeadDetector = struct { | |||
|
|
|||
| fn is_entry_point(file: FileName) bool { | |||
| const entry_points: []const []const u8 = &.{ | |||
| "benchmark.zig", | |||
There was a problem hiding this comment.
Funny how this tidy check was explicitly designed to catch dead files like this, but this particular one dodged the check, because I was lazy and implemnted the check based solely on the file name, and not on the entire path (and we used to have benchmark entry points)
kprotty
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This benchmark doesn't compile, and it looks like it wansn't even ported to Zig 0.11. As we don't actively need it, remove it