Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devhub: track p100 rather than p99 #1963

Merged
merged 1 commit into from
May 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/scripts/devhub.zig
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ pub fn main(shell: *Shell, gpa: std.mem.Allocator, cli_args: CliArgs) !void {

const benchmark_result = try shell.exec_stdout("./tigerbeetle benchmark", .{});
const tps = try get_measurement(benchmark_result, "load accepted", "tx/s");
const batch_p99_ms = try get_measurement(benchmark_result, "batch latency p99", "ms");
const query_p99_ms = try get_measurement(benchmark_result, "query latency p99", "ms");
const batch_p100_ms = try get_measurement(benchmark_result, "batch latency p100", "ms");
const query_p100_ms = try get_measurement(benchmark_result, "query latency p100", "ms");
const rss_bytes = try get_measurement(benchmark_result, "rss", "bytes");
const datafile_bytes = try get_measurement(benchmark_result, "datafile", "bytes");

Expand All @@ -50,8 +50,8 @@ pub fn main(shell: *Shell, gpa: std.mem.Allocator, cli_args: CliArgs) !void {
.{ .name = "build time", .value = build_time_ms, .unit = "ms" },
.{ .name = "executable size", .value = executable_size_bytes, .unit = "bytes" },
.{ .name = "TPS", .value = tps, .unit = "count" },
.{ .name = "batch p99", .value = batch_p99_ms, .unit = "ms" },
.{ .name = "query p99", .value = query_p99_ms, .unit = "ms" },
.{ .name = "batch p100", .value = batch_p100_ms, .unit = "ms" },
.{ .name = "query p100", .value = query_p100_ms, .unit = "ms" },
.{ .name = "RSS", .value = rss_bytes, .unit = "bytes" },
.{ .name = "datafile", .value = datafile_bytes, .unit = "bytes" },
},
Expand Down