Simulator coverage for get_account_{transfers,balances} #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batiati
force-pushed
the
batiati-simulator
branch
from
8dfc5ea
to
f1a1ecf
Compare
Merged
matklad
reviewed
Jun 18, 2024
matklad
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Realized that I don't understand one big picture aspect of this: in validate_account_filter_result_count, we compare the number of transfers the account has at a given moment with the amount of results. But why than works? More transfers could get created in the meantime, no?
|
removed vopr label until this is rebased to 0.13 :) |
batiati
force-pushed
the
batiati-simulator
branch
from
4684efb
to
639baba
Compare
Implemented assertions based on the expected number of results in variations of filters such as `debits | credits` and timestamp range. It's not able to fine-check intermediate states such as the expected `account_balance` between transfers, although the path covered is good enough to check the assertions already in place along the code.
batiati
force-pushed
the
batiati-simulator
branch
from
639baba
to
6ef6d2c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
matklad
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented assertions based on the expected number of results in variations of filters such as
debits | creditsand timestamp range.It's not able to fine-check intermediate states such as the expected
account_balancebetween transfers, although the path covered is good enough to check the assertions already in place along the code.