LSM,VSR: Backport std HashMap fix #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In zig 0.9.1 (and zig master, as of writing this) `fetchRemove` does not increment `available`. So it leaks slots. Currently we only use `fetchRemove` in the mutable table and the client sessions. Note that the VOPR didn't find this bug in client sessions because evictions are not tested. It probably didn't find it in the mutable table because we often use `createRetainingCapacity()`, which restores the leaked slots. Backport the fix: ziglang/zig#15989.
jorangreef
reviewed
Jun 13, 2023
The backported hashmap is only needed when we use |
jorangreef
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In zig 0.9.1 (and zig master, as of writing this)
fetchRemovedoes not incrementavailable.So it leaks slots.
Currently we only use
fetchRemovein the mutable table and the client sessions.Note that the VOPR didn't find this bug in client sessions because evictions are not tested.
It probably didn't find it in the mutable table because we often use
createRetainingCapacity(), which restores the leaked slots.Backport the fix: ziglang/zig#15989.