Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use prefix "" when cursor is at trigger character #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use prefix "" when cursor is at trigger character #123

wants to merge 1 commit into from

Conversation

yyoncho
Copy link
Contributor

@yyoncho yyoncho commented Sep 11, 2019

Fixes #122

@yyoncho
Copy link
Contributor Author

yyoncho commented Sep 11, 2019

CC @muirrn

@muirdm
Copy link

muirdm commented Sep 11, 2019

What about cases like fmt.Pri<>nt()? I don't necessarily think it is important, but it is a difference between VSCode so I want to consider it.

@muirdm
Copy link

muirdm commented Sep 11, 2019

This seems to break the normal trigger character behavior. For example, fmt.<> doesn't trigger completions automatically anymore.

@yyoncho
Copy link
Contributor Author

yyoncho commented Sep 11, 2019

What about cases like fmt.Pri<>nt()? I don't necessarily think it is important, but it is a difference between VSCode so I want to consider it.

It makes sense to support that as well. I will spend some more time into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't trigger completions in or before symbol.
2 participants
@yyoncho @muirdm